[PATCH] drm/amd/display: Disable 4k at 60 on DP as well for DCE11

Wentland, Harry Harry.Wentland at amd.com
Wed Nov 28 15:47:35 UTC 2018


On 2018-11-27 3:52 a.m., S, Shirish wrote:
> This patch extends the below patch to apply DP signal type, for exactly
> the same reasons it was disabled for HDMI.
> 
> "1a0e348 drm/amd/display: Disable 4k 60 HDMI on DCE11"
> 
> Signed-off-by: Shirish S <shirish.s at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> index 3e18ea8..d578828 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> @@ -662,6 +662,10 @@ bool dce110_link_encoder_validate_dp_output(
>  	const struct dce110_link_encoder *enc110,
>  	const struct dc_crtc_timing *crtc_timing)
>  {
> +	if (crtc_timing->pix_clk_khz >
> +		enc110->base.features.max_hdmi_pixel_clock)
> +		return false;
> +

It doesn't make sense to look at the max hdmi pixel for DP.

If we want to restrict the supported timings we should also make sure they only apply to Stoney and/or Carrizo. That said, are you sure 4k60 is an issue on all CZ/ST boards or is this particular to a certain platform?

Harry

>  	if (crtc_timing->pixel_encoding == PIXEL_ENCODING_YCBCR420)
>  		return false;
>  
> 


More information about the amd-gfx mailing list