[PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

[Alex Deucher]

On Wed, Oct 3, 2018 at 7:11 AM Rex Zhu <Rex.Zhu at amd.com> wrote:
>
> driver don't release the ucode memory when suspend. so don't
> need to allocate bo when resume back.
>
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index 9878212..adfeb93 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -434,7 +434,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
>                 return 0;
>         }
>
> -       if (!adev->in_gpu_reset) {
> +       if (!adev->in_gpu_reset && !adev->in_suspend) {
>                 err = amdgpu_bo_create_kernel(adev, adev->firmware.fw_size, PAGE_SIZE,
>                                         amdgpu_sriov_vf(adev) ? AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT,
>                                         &adev->firmware.fw_buf,

Not sure if we support S3 in SR-IOV, but I think this will break it
because we'll lose vram contents and not re-init it.

Alex

> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx