[PATCH] drm/radeon: ratelimit bo warnings

[Michel Dänzer]

On 2018-10-04 9:58 p.m., Nick Alcock wrote:
> So a few days ago I started getting sprays of these warnings --
> sorry, but because it was a few days ago I'm not sure what I was
> running at the time (but it was probably either Stellaris or Chromium).
> 
> Sep 25 22:06:34 mutilate err: : [  544.718905] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.718909] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.719710] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.719714] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.719862] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.719865] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!
> Sep 25 22:06:34 mutilate err: : [  544.720772] [drm:radeon_cs_parser_relocs] *ERROR* gem object lookup failed 0xc
> Sep 25 22:06:34 mutilate err: : [  544.720778] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -2!

These are likely due to https://bugs.freedesktop.org/105381 , fixed in
xf86-video-ati 18.1.0.


> Sep 25 22:06:34 mutilate warning: : [  544.721415] radeon 0000:01:00.0: vbo resource seems too big for the bo

Not sure this can also be caused by the above, but I guess it's possible.


> followed by a massive stream of "vbo resource seems too big for the bo".
> 
> The most extreme flood ran from 23:01:58 to 23:02:47 and emitted 91,000
> lines of log in that time.  This... seems excessive, given that each log
> message after the first contains more or less no information.
> 
> So ratelimit these messages. (We probably want to see at least *some* so
> that the underlying bug can be fixed -- always assuming the bug isn't in
> unfixable closed-source game code somewhere.)
> 
> This patch is against 4.18.11: I saw the warnings on 4.17.6 with Mesa
> 18.1.2, but nothing much seems to have changed in this area so I bet
> this could recur.

Not sure it makes sense to have the last paragraph in the Git commit
log, but either way:

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>  drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 54324330b91f..f471537c852f 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -2416,7 +2416,7 @@ static int evergreen_packet3_check(struct radeon_cs_parser *p,
>  				size = radeon_get_ib_value(p, idx+1+(i*8)+1);
>  				if (p->rdev && (size + offset) > radeon_bo_size(reloc->robj)) {
>  					/* force size to size of the buffer */
> -					dev_warn(p->dev, "vbo resource seems too big for the bo\n");
> +					dev_warn_ratelimited(p->dev, "vbo resource seems too big for the bo\n");
>  					ib[idx+1+(i*8)+1] = radeon_bo_size(reloc->robj) - offset;
>  				}
>  
> 




-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer