[PATCH] Updated comment accuracy in PSP SOS/Sysdriver loading sequence to target bootloader instead of bootrom

Huang Rui ray.huang at amd.com
Wed Oct 10 03:32:26 UTC 2018


On Tue, Oct 09, 2018 at 05:51:32PM -0400, John Clements wrote:
> From: John Clements <clements.jm at gmail.com>
> 

Please add commit comment and signed-off in the patch.

Thanks,
Ray

> ---
>  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++--
>  drivers/gpu/drm/amd/amdgpu/psp_v3_1.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index b70cfa3fe1b2..3fe30eb46d26 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp)
>  	/* Copy PSP System Driver binary to memory */
>  	memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size);
>  
> -	/* Provide the sys driver to bootrom */
> +	/* Provide the sys driver to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 1 << 16;
> @@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct psp_context *psp)
>  	/* Copy Secure OS binary to PSP memory */
>  	memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size);
>  
> -	/* Provide the PSP secure OS to bootrom */
> +	/* Provide the PSP secure OS to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 2 << 16;
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> index e1ebf770c303..9cea0bbe4525 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> @@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct psp_context *psp)
>  	/* Copy PSP System Driver binary to memory */
>  	memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size);
>  
> -	/* Provide the sys driver to bootrom */
> +	/* Provide the sys driver to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 1 << 16;
> @@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct psp_context *psp)
>  	/* Copy Secure OS binary to PSP memory */
>  	memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size);
>  
> -	/* Provide the PSP secure OS to bootrom */
> +	/* Provide the PSP secure OS to bootloader */
>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_36,
>  	       (uint32_t)(psp->fw_pri_mc_addr >> 20));
>  	psp_gfxdrv_command_reg = 2 << 16;
> -- 
> 2.17.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list