[PATCH 2/7] drm: add syncobj timeline support v8

Koenig, Christian Christian.Koenig at amd.com
Wed Oct 17 09:29:01 UTC 2018


Am 17.10.18 um 11:17 schrieb zhoucm1:
> [SNIP]
>>>   +struct drm_syncobj_signal_pt {
>>> +    struct dma_fence_array *base;
>> Out of curiosity, why the pointer and not embedding? base is kinda
>> misleading for a pointer.
> Yeah, Christian doesn't like signal_pt lifecycle same as fence, so 
> it's a pointer.
> If you don't like 'base' name, I can change it.

Well I never said that you can't embed the fence array into the signal_pt.

You just need to make sure that we don't affect the drm_syncobj 
lilecycle as well, e.g. that we don't also need to keep that around.

Regards,
Christian.


More information about the amd-gfx mailing list