[PATCH] powerplay: Respect units on max dcfclk watermark

Wentland, Harry Harry.Wentland at amd.com
Thu Oct 18 15:54:48 UTC 2018


On 2018-10-18 11:30 a.m., David Francis wrote:
> In a refactor, the watermark clock inputs to
> powerplay from DC were changed from units of 10kHz to
> kHz clocks.
> 
> One division by 100 was not converted into a division
> by 1000.
> 
> Signed-off-by: David Francis <David.Francis at amd.com>

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
> index 4714b5b59825..99a33c33a32c 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
> @@ -718,7 +718,7 @@ int smu_set_watermarks_for_clocks_ranges(void *wt_table,
>  		table->WatermarkRow[1][i].MaxClock =
>  			cpu_to_le16((uint16_t)
>  			(wm_with_clock_ranges->wm_dmif_clocks_ranges[i].wm_max_dcfclk_clk_in_khz) /
> -			100);
> +			1000);
>  		table->WatermarkRow[1][i].MinUclk =
>  			cpu_to_le16((uint16_t)
>  			(wm_with_clock_ranges->wm_dmif_clocks_ranges[i].wm_min_mem_clk_in_khz) /
> 


More information about the amd-gfx mailing list