[PATCH] drm/amdgpu: Limit vm max ctx number to 4096

Christian König ckoenig.leichtzumerken at gmail.com
Wed Oct 24 09:28:53 UTC 2018


Am 24.10.18 um 10:47 schrieb Rex Zhu:
> driver need to reserve resource for each ctx for
> some hw features. so add this limitation.
>
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 33f5f2c..26f11eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -161,6 +161,7 @@ struct amdgpu_mgpu_info
>   extern int amdgpu_cik_support;
>   #endif
>   
> +#define VM_MAX_NUM_CTX		4096

Please add AMDGPU_ as prefix to this define.

Apart from that looks good to me,
Christian.

>   #define AMDGPU_SG_THRESHOLD			(256*1024*1024)
>   #define AMDGPU_DEFAULT_GTT_SIZE_MB		3072ULL /* 3GB by default */
>   #define AMDGPU_WAIT_IDLE_TIMEOUT_IN_MS	        3000
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> index f9b5423..08b47dc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> @@ -247,7 +247,7 @@ static int amdgpu_ctx_alloc(struct amdgpu_device *adev,
>   		return -ENOMEM;
>   
>   	mutex_lock(&mgr->lock);
> -	r = idr_alloc(&mgr->ctx_handles, ctx, 1, 0, GFP_KERNEL);
> +	r = idr_alloc(&mgr->ctx_handles, ctx, 1, VM_MAX_NUM_CTX, GFP_KERNEL);
>   	if (r < 0) {
>   		mutex_unlock(&mgr->lock);
>   		kfree(ctx);



More information about the amd-gfx mailing list