[PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

Yu, Qiang Qiang.Yu at amd.com
Mon Sep 3 08:03:05 UTC 2018


Thanks Jerry.

Hi Christian,

This is an old patch back to 2016 reviewed in hybrid list. If you are OK with it,
would you please submit it to upstream?

Thanks,
Qiang

________________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Zhang, Jerry (Junwei) <Jerry.Zhang at amd.com>
Sent: Monday, September 3, 2018 3:18:14 PM
To: Yu, Qiang; amd-gfx at lists.freedesktop.org
Cc: Koenig, Christian; Deng, Hui
Subject: Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

On 09/03/2018 02:55 PM, Qiang Yu wrote:
> For Pro OGL be able to work with upstream libdrm.
>
> Signed-off-by: Qiang Yu <Qiang.Yu at amd.com>
> Reviewed-by: Christian König <christian.koenig at amd.com>

I'm fine with that, not sure if mesa is going to use that as well.

Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com>

Regards,
Jerry

> ---
>   amdgpu/amdgpu-symbol-check |  1 +
>   amdgpu/amdgpu.h            | 15 ++++++++++++++-
>   amdgpu/amdgpu_bo.c         |  6 ++++++
>   3 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
> index b5e4fe6..487610e 100755
> --- a/amdgpu/amdgpu-symbol-check
> +++ b/amdgpu/amdgpu-symbol-check
> @@ -15,6 +15,7 @@ amdgpu_bo_cpu_map
>   amdgpu_bo_cpu_unmap
>   amdgpu_bo_export
>   amdgpu_bo_free
> +amdgpu_bo_inc_ref
>   amdgpu_bo_import
>   amdgpu_bo_list_create
>   amdgpu_bo_list_destroy
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index a8c353c..e1f93f8 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -721,7 +721,20 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
>   int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
>
>   /**
> - * Request CPU access to GPU accessible memory
> + * Increase the reference count of a buffer object
> + *
> + * \param   bo - \c [in]  Buffer object handle to increase the reference count
> + *
> + * \return   0 on success\n
> + *          <0 - Negative POSIX Error code
> + *
> + * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
> + *
> +*/
> +int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
> +
> +/**
> + * Request CPU access to GPU accessable memory
>    *
>    * \param   buf_handle - \c [in] Buffer handle
>    * \param   cpu        - \c [out] CPU address to be used for access
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index a2fc525..dceab01 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -438,6 +438,12 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
>       return 0;
>   }
>
> +int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
> +{
> +     atomic_inc(&bo->refcount);
> +     return 0;
> +}
> +
>   int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
>   {
>       union drm_amdgpu_gem_mmap args;
>
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list