[PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

Yu, Qiang Qiang.Yu at amd.com
Mon Sep 3 09:52:45 UTC 2018


>>  amdgpu_bo_free
>> +amdgpu_bo_inc_ref
>>  amdgpu_bo_import
>>  amdgpu_bo_list_create
>>  amdgpu_bo_list_destroy
>
> Thanks for remembering to add the symbol here, but amdgpu_bo_inc_ref
> goes after amdgpu_bo_import in lexical order. :)
Oh, haven't notice this is in alphabetic order.

>>
>> +int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
>> +{
>> +     atomic_inc(&bo->refcount);
>> +     return 0;
>> +}
>
> What's the point of having a non-void return value that's always 0?
Indeed no actual functionality, will prepare a patch for removing it.

Thanks,
Qiang



More information about the amd-gfx mailing list