[PATCH] [RFC]drm: add syncobj timeline support v5

[Christian König]

Am 19.09.2018 um 05:20 schrieb zhoucm1:
>
>
>
> On 2018年09月18日 16:32, Christian König wrote:
>>>>> +    for (i = 0; i < args->count_handles; i++) {
>>>>> +        if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
>>>>> +            DRM_ERROR("timeline syncobj cannot reset!\n");
>>>>
>>>> Why not? I mean that should still work or do I miss anything?
>>> timeline semaphore spec doesn't require reset interface, it says the 
>>> timeline value only can be changed by signal operations.
>>
>> Yeah, but we don't care about the timeline spec in the kernel.
>>
>> Question is rather if that still makes sense to support that and as 
>> far as I can see it should be trivial to reinitialize the object. 
> Hi Daniel Rakos,
>
> Could you give a comment on this question? Is it necessary to support 
> timeline reset interface?  I only see the timeline value can be 
> changed by signal operations in Spec.

I think the Vulkan spec is rather irrelevant here. We added the reset 
operation because of drivers which wanted to re-use an existing syncobj.

That is still a valid use case even when Vulkan doesn't have an 
interface for it.

Christian.

>
>
> Thanks,
> David Zhou
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180919/7d956aa6/attachment.html>