[PATCH 3/7] drm/amd/pp: Remove uncessary extra vcn pg cntl in smu

[Alex Deucher]

On Wed, Sep 26, 2018 at 8:52 AM Rex Zhu <Rex.Zhu at amd.com> wrote:
>
> the vcn power will be controlled by VCN.
>
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c
> index d78d864..d0eb8ab 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c
> @@ -186,26 +186,12 @@ static int smu10_verify_smc_interface(struct pp_hwmgr *hwmgr)
>         return 0;
>  }
>
> -/* vcn is disabled by default in vbios, need to re-enable in driver */
> -static void smu10_smc_enable_vcn(struct pp_hwmgr *hwmgr)
> -{
> -       smu10_send_msg_to_smc_with_parameter(hwmgr,
> -                       PPSMC_MSG_PowerUpVcn, 0);
> -}
> -
> -static void smu10_smc_disable_vcn(struct pp_hwmgr *hwmgr)
> -{
> -       smu10_send_msg_to_smc_with_parameter(hwmgr,
> -                       PPSMC_MSG_PowerDownVcn, 0);
> -}
> -
>  static int smu10_smu_fini(struct pp_hwmgr *hwmgr)
>  {
>         struct smu10_smumgr *priv =
>                         (struct smu10_smumgr *)(hwmgr->smu_backend);
>
>         if (priv) {
> -               smu10_smc_disable_vcn(hwmgr);
>                 amdgpu_bo_free_kernel(&priv->smu_tables.entry[SMU10_WMTABLE].handle,
>                                         &priv->smu_tables.entry[SMU10_WMTABLE].mc_addr,
>                                         &priv->smu_tables.entry[SMU10_WMTABLE].table);
> @@ -229,7 +215,7 @@ static int smu10_start_smu(struct pp_hwmgr *hwmgr)
>
>         if (smu10_verify_smc_interface(hwmgr))
>                 return -EINVAL;
> -       smu10_smc_enable_vcn(hwmgr);
> +
>         return 0;
>  }
>
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx