print firmware versions on amdgpu sysfs

[Christian König]

We just need to keep in mind that sysfs has more restrictions than debugfs.

E.g. one value per file, backward compatibility etc...

Apart from that I don't see any reason to not do it in sysfs.

Christian.

Am 26.04.19 um 20:35 schrieb Russell, Kent:
> The main reasoning and use case for sysfs would be the SMI CLI, since 
> unfortunately there is no ioctl support in there.
>
> Kent
>
> KENT RUSSELL
> Sr. Software Engineer | Linux Compute Kernel
> 1 Commerce Valley Drive East
> Markham, ON L3T 7X6
> O +(1) 289-695-2122 | Ext 72122
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of 
> Deucher, Alexander <Alexander.Deucher at amd.com>
> *Sent:* Friday, April 26, 2019 12:18:22 PM
> *To:* Lin, Amber; amd-gfx at lists.freedesktop.org
> *Cc:* Freehill, Chris
> *Subject:* Re: print firmware versions on amdgpu sysfs
> We also expose the firmware versions via ioctl which is what the UMDs 
> uses.  If you'd prefer it in sysfs, we could do that too.
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of 
> Lin, Amber <Amber.Lin at amd.com>
> *Sent:* Friday, April 26, 2019 10:14 AM
> *To:* amd-gfx at lists.freedesktop.org
> *Cc:* Freehill, Chris
> *Subject:* print firmware versions on amdgpu sysfs
> Hi Alex,
>
> Currently we retrieve firmware versions from /sys/kernel/debug but this
> requires debugfs being enabled and superuser privilege. Do you see a
> concern we add firmware versions to amdgpu sysfs at
> /sys/class/drm/cardX/device like vbios_version?
>
> Regards,
> Amber
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190429/d7003e5c/attachment.html>