[PATCH] drm/amd/amdgpu: Update VM function pointer

Christian König ckoenig.leichtzumerken at gmail.com
Wed Aug 14 17:59:49 UTC 2019


Am 14.08.19 um 19:35 schrieb Gang Ba:
>    When VM state changed and system in large bar mode,
>    make sure to use CPU update function, otherwise use
>    SDMA function.

Looks like you have some extra spaces in front of the commit message.

Apart from that looks good to me now and fix the commit message fixed it 
is Reviewed-by: Christian König <christian.koenig at amd.com>

Regards,
Christian.

>
> Change-Id: Ibcfada560a00c9aeebfd922ae48de920e44a5866
> Signed-off-by: Gang Ba <gaba at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index c1baf3d..7ddca3e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2862,6 +2862,13 @@ int amdgpu_vm_make_compute(struct amdgpu_device *adev, struct amdgpu_vm *vm, uns
>   	WARN_ONCE((vm->use_cpu_for_update && !amdgpu_gmc_vram_full_visible(&adev->gmc)),
>   		  "CPU update of VM recommended only for large BAR system\n");
>   
> +	if (vm->use_cpu_for_update)
> +		vm->update_funcs = &amdgpu_vm_cpu_funcs;
> +	else
> +		vm->update_funcs = &amdgpu_vm_sdma_funcs;
> +	dma_fence_put(vm->last_update);
> +	vm->last_update = NULL;
> +
>   	if (vm->pasid) {
>   		unsigned long flags;
>   



More information about the amd-gfx mailing list