[PATCH] drm/amdgpu: Apply flags after amdgpu_device_ip_init()

Alex Deucher alexdeucher at gmail.com
Thu Aug 15 15:28:01 UTC 2019

On Thu, Aug 15, 2019 at 10:59 AM Kai-Heng Feng
<kai.heng.feng at canonical.com> wrote:
> at 21:33, Deucher, Alexander <Alexander.Deucher at amd.com> wrote:
> > Thanks for finding this!  I think the attached patch should fix the issue
> > and it's much less invasive.
> Yes it also fix the issue, please add by tested-by:
> Tested-by: Kai-Heng Feng <kai.heng.feng at canonical.com>


> I took this more or less future proof approach because I think this won’t
> be the last chip that needs firmware information, which isn’t available in
> early init, to decides its flags.
> Yes it’s intrusive to carve out all flags from early init callbacks, but I
> don’t think it’s that ugly.

Not a bad approach, but I'd prefer to keep the power and clock gating
flags in the asic specifc code rather than in the common code.


More information about the amd-gfx mailing list