[PATCH libdrm] amdgpu: add mmhub ras inject unit test

Koenig, Christian Christian.Koenig at amd.com
Mon Aug 19 07:14:10 UTC 2019


Hi Guchun,

in this case this is a bit awkward implemented.

See the files in the data directory are for installation together with 
the libdrm library and NOT for the unit tests. Please move the file to 
tests/amdgpu instead.

I would also re-consider this approach since we intentionally use the 
CUnit framework to avoid dependencies on external libraries like json 
and external files.

We should probably better configure the tests directly in the C code so 
that the unit test stays self containing.

Regards,
Christian.

Am 19.08.19 um 05:16 schrieb Chen, Guchun:
> Hi Christian,
>
> Yes, we added one configuration file named "amdgpu_ras.json" for RAS inject unit test to drm master branch.
> This unit test will be maintained to illustrate all the RAS tests we absolutely support in IP modules/submodules.
>
> Regards,
> Guchun
>
> -----Original Message-----
> From: Christian K├Ânig <ckoenig.leichtzumerken at gmail.com>
> Sent: Friday, August 16, 2019 7:12 PM
> To: Chen, Guchun <Guchun.Chen at amd.com>; amd-gfx at lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang at amd.com>; Li, Dennis <Dennis.Li at amd.com>; Cui, Flora <Flora.Cui at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>
> Cc: Li, Candice <Candice.Li at amd.com>
> Subject: Re: [PATCH libdrm] amdgpu: add mmhub ras inject unit test
>
> Well this doesn't look like C to me. Did we added a configuration file for the ras unit tests or something like that?
>
> Christian.
>
> Am 16.08.19 um 13:04 schrieb Guchun Chen:
>> Change-Id: Ia76b95162f5f6f419f70b53ef443bceaf2e092e0
>> Signed-off-by: Guchun Chen <guchun.chen at amd.com>
>> ---
>>    data/amdgpu_ras.json | 10 ++++++++++
>>    1 file changed, 10 insertions(+)
>>
>> diff --git a/data/amdgpu_ras.json b/data/amdgpu_ras.json index
>> 26fd9465..484f12f2 100644
>> --- a/data/amdgpu_ras.json
>> +++ b/data/amdgpu_ras.json
>> @@ -121,6 +121,9 @@
>>                    "utc_atcl2_cache_4k_bank": 111
>>                }
>>            },
>> +        "mmhub": {
>> +            "index": 3
>> +        },
>>        },
>>        "type": {
>>            "parity": 1,
>> @@ -263,5 +266,12 @@
>>                "address": 0,
>>                "value": 0
>>            },
>> +        {
>> +            "name": "ras_mmhub.1.0",
>> +            "block": "mmhub",
>> +            "type": "single_correctable",
>> +            "address": 0,
>> +            "value": 0
>> +        },
>>        ]
>>    }



More information about the amd-gfx mailing list