[PATCH 1/4] drm/amdgpu: Extends amdgpu vm definitions (v2)

Koenig, Christian Christian.Koenig at amd.com
Tue Aug 27 08:56:41 UTC 2019


Am 27.08.19 um 01:07 schrieb Kuehling, Felix:
> From: Oak Zeng <Oak.Zeng at amd.com>
>
> Add RW mtype introduced for arcturus.
>
> v2:
> * Don't add probe-invalidation bit from UAPI
> * Don't add unused AMDGPU_MTYPE_ definitions
>
> Signed-off-by: Oak Zeng <Oak.Zeng at amd.com>
> Signed-off-by: Felix Kuehling <Felix.Kuehling at amd.com>

We should have used the hardware value here in the first place (e.g. a 
mask and a shift), but now it is probably to late to actually fix that.

Reviewed-by: Christian K├Ânig <christian.koenig at amd.com>

> ---
>   include/uapi/drm/amdgpu_drm.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
> index ca97b6802275..f3ad429173e3 100644
> --- a/include/uapi/drm/amdgpu_drm.h
> +++ b/include/uapi/drm/amdgpu_drm.h
> @@ -503,6 +503,8 @@ struct drm_amdgpu_gem_op {
>   #define AMDGPU_VM_MTYPE_CC		(3 << 5)
>   /* Use UC MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_UC		(4 << 5)
> +/* Use RW MTYPE instead of default MTYPE */
> +#define AMDGPU_VM_MTYPE_RW		(5 << 5)
>   
>   struct drm_amdgpu_gem_va {
>   	/** GEM object handle */



More information about the amd-gfx mailing list