[PATCH] amd/amdgpu/sriov swSMU disable for sriov

[Zhang, Jack (Jian)]

Thanks Evan, I will add "{ }" before I check-in the code.

Best,
Jack

-----Original Message-----
From: Quan, Evan <Evan.Quan at amd.com> 
Sent: Tuesday, December 3, 2019 10:45 AM
To: Zhang, Jack (Jian) <Jack.Zhang1 at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Zhang, Jack (Jian) <Jack.Zhang1 at amd.com>
Subject: RE: [PATCH] amd/amdgpu/sriov swSMU disable for sriov



> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of 
> Jack Zhang
> Sent: Monday, December 2, 2019 7:05 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhang, Jack (Jian) <Jack.Zhang1 at amd.com>
> Subject: [PATCH] amd/amdgpu/sriov swSMU disable for sriov
> 
> For boards greater than ARCTURUS, and under sriov platform, swSMU is 
> not supported because smu ip block is commented at guest driver.
> 
> Generally for sriov, initialization of smu is moved to host driver.
> Thus, smu sw_init and hw_init will not be executed at guest driver.
> 
> Without sw structure being initialized in guest driver, swSMU cannot 
> declare to be supported.
> 
> Signed-off-by: Jack Zhang <Jack.Zhang1 at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 36001a4..0b8a53b 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -531,7 +531,10 @@ bool is_support_sw_smu(struct amdgpu_device *adev)
>  	if (adev->asic_type == CHIP_VEGA20)
>  		return (amdgpu_dpm == 2) ? true : false;
>  	else if (adev->asic_type >= CHIP_ARCTURUS)
> -		return true;
> +		if (amdgpu_sriov_vf(adev))
> +			return false;
> +		else
> +			return true;
[Quan, Evan] Are "{" and "}" missing around this code block? This seems a little weird.
>  	else
>  		return false;
>  }
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.free
> desktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=02%7C01%7Cevan.quan%40amd.com%7Ca0119099a3db450554
> f208d777178b5f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6371
> 08815384772040&sdata=8RJ1QyDzHEcnOnk0EBGkhfVljeiPWaZSNlO6OyAa
> enc%3D&reserved=0