[PATCH v2] drm/amd/powerplay: Copy watermark to SMU
Zhan Liu
zhan.liu at amd.com
Fri Dec 13 16:01:47 UTC 2019
[Why]
Watermark value was expected to copy to SMU
within navi10_display_config_changed(). But
navi10_display_config_changed() is never called.
As a result, the watermark value is never
copied to SMU.
[How]
At end of navi10_set_watermarks_table,
copy watermark to SMU.
Signed-off-by: Zhan Liu <zhan.liu at amd.com>
Signed-off-by: Hersen Wu <hersenxs.wu at amd.com>
---
drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
index 15403b7979d6..ad6775c6839f 100644
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -1472,6 +1472,17 @@ static int navi10_set_watermarks_table(struct smu_context *smu,
clock_ranges->wm_mcif_clocks_ranges[i].wm_set_id;
}
+ /* Pass data to smu controller */
+ if ((smu->watermarks_bitmap & WATERMARKS_EXIST) &&
+ !(smu->watermarks_bitmap & WATERMARKS_LOADED)) {
+ ret = smu_write_watermarks_table(smu);
+ if (ret) {
+ pr_err("Failed to update WMTABLE!");
+ return ret;
+ }
+ smu->watermarks_bitmap |= WATERMARKS_LOADED;
+ }
+
return 0;
}
--
2.17.1
Hi all,
Navi10 has been upstreamed, so I will directly mail v2 patch
to amd-gfx. Please kindly review this patch again.
Thanks,
Zhan
More information about the amd-gfx
mailing list