[PATCH] drm/amd/powerplay: Add SMU WMTABLE Validity Check for Renoir

[Liu, Zhan]

Ping...

> -----Original Message-----
> From: Liu, Zhan <Zhan.Liu at amd.com>
> Sent: 2019/December/13, Friday 11:50 AM
> To: amd-gfx at lists.freedesktop.org; Wu, Hersen <hersenxs.wu at amd.com>;
> Deucher, Alexander <Alexander.Deucher at amd.com>; Wang, Kevin(Yang)
> <Kevin1.Wang at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Yin, Tianci
> (Rico) <Tianci.Yin at amd.com>
> Cc: Liu, Zhan <Zhan.Liu at amd.com>
> Subject: [PATCH] drm/amd/powerplay: Add SMU WMTABLE Validity Check
> for Renoir
> 
> [Why]
> SMU watermark table (WMTABLE) validity check is missing on Renoir. This
> validity check is very useful for checking whether WMTABLE is updated
> successfully.
> 
> [How]
> Add SMU watermark validity check.
> 
> Signed-off-by: Zhan Liu <zhan.liu at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 89a54f8e08d3..81520b0fca68 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -777,9 +777,17 @@ static int renoir_set_watermarks_table(
>  	}
> 
>  	/* pass data to smu controller */
> -	ret = smu_write_watermarks_table(smu);
> +	if ((smu->watermarks_bitmap & WATERMARKS_EXIST) &&
> +			!(smu->watermarks_bitmap &
> WATERMARKS_LOADED)) {
> +		ret = smu_write_watermarks_table(smu);
> +		if (ret) {
> +			pr_err("Failed to update WMTABLE!");
> +			return ret;
> +		}
> +		smu->watermarks_bitmap |= WATERMARKS_LOADED;
> +	}
> 
> -	return ret;
> +	return 0;
>  }
> 
>  static int renoir_get_power_profile_mode(struct smu_context *smu,
> --
> 2.17.1