[PATCH] drm/amd/powerplay: suppress nonsupport profile mode overrun message

Quan, Evan Evan.Quan at amd.com
Thu Dec 19 07:00:24 UTC 2019


Reviewed-by: Evan Quan <evan.quan at amd.com>

> -----Original Message-----
> From: Liang, Prike <Prike.Liang at amd.com>
> Sent: Thursday, December 19, 2019 2:46 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Quan, Evan <Evan.Quan at amd.com>; Huang, Ray <Ray.Huang at amd.com>;
> Dai, Yuxian (David) <Yuxian.Dai at amd.com>; Liang, Prike
> <Prike.Liang at amd.com>
> Subject: [PATCH] drm/amd/powerplay: suppress nonsupport profile mode
> overrun message
> 
> SMU12 not support WORKLOAD_DEFAULT_BIT and
> WORKLOAD_PPLIB_POWER_SAVING_BIT.
> 
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 784903a3..f9a1817 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -550,14 +550,18 @@ static int renoir_set_power_profile_mode(struct
> smu_context *smu, long *input, u
>  	/* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */
>  	workload_type = smu_workload_get_type(smu, smu-
> >power_profile_mode);
>  	if (workload_type < 0) {
> -		pr_err("Unsupported power profile mode %d on
> RENOIR\n",smu->power_profile_mode);
> +		/*
> +		 * TODO: If some case need switch to powersave/default
> power mode
> +		 * then can consider enter
> WORKLOAD_COMPUTE/WORKLOAD_CUSTOM for power saving.
> +		 */
> +		pr_err_once("Unsupported power profile mode %d on
> RENOIR\n",smu->power_profile_mode);
>  		return -EINVAL;
>  	}
> 
>  	ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_SetWorkloadMask,
>  				    1 << workload_type);
>  	if (ret) {
> -		pr_err("Fail to set workload type %d\n", workload_type);
> +		pr_err_once("Fail to set workload type %d\n", workload_type);
>  		return ret;
>  	}
> 
> --
> 2.7.4



More information about the amd-gfx mailing list