[PATCH] Series to re-organize and amalgamate certain PSP TA functions

[Clements, John]

[AMD Official Use Only - Internal Distribution Only]

Hello Guchun,

Thank you for your feedback, I have updated the indentations to make them consistent.

I am not so sure if the psp_ta_invoke function should be a static function. As the Linux TA count grows, we may want to split up amdgpu_psp.c  to leverage the psp_ta_invoke function from other TA dedicated source file.

Thank you,
John Clements

From: Chen, Guchun <Guchun.Chen at amd.com>
Sent: Wednesday, December 25, 2019 9:17 AM
To: Clements, John <John.Clements at amd.com>; amd-gfx at lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: RE: [PATCH] Series to re-organize and amalgamate certain PSP TA functions


[AMD Official Use Only - Internal Distribution Only]

In patch 3,
1. psp_ta_invoke should be one static function?
2. The indentation in each "return" line looks not correct.

With above fixed, series is:
Reviewed-by: Guchun Chen <guchun.chen at amd.com<mailto:guchun.chen at amd.com>>.

From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org<mailto:amd-gfx-bounces at lists.freedesktop.org>> On Behalf Of Clements, John
Sent: Tuesday, December 24, 2019 11:33 PM
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Subject: [PATCH] Series to re-organize and amalgamate certain PSP TA functions


[AMD Official Use Only - Internal Distribution Only]

Patch 1:

  *   Update PSP command submission to output failure to dmesg by default
  *   Removed masking of response status (as requested by PSP team)

Patch 2:

  *   Unify TA function to prepare load/unload commands

Patch 3:

  *   Unify TA function to invoke commands

Thank you,
John Clements
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191226/70e60c07/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-drm-amdgpu-amalgamated-PSP-TA-invoke-functions.patch
Type: application/octet-stream
Size: 5815 bytes
Desc: 0003-drm-amdgpu-amalgamated-PSP-TA-invoke-functions.patch
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191226/70e60c07/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amdgpu-by-default-output-PSP-ret-status-in-event-.patch
Type: application/octet-stream
Size: 1243 bytes
Desc: 0001-drm-amdgpu-by-default-output-PSP-ret-status-in-event-.patch
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191226/70e60c07/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-drm-amdgpu-amalgamate-PSP-TA-load-unload-functions.patch
Type: application/octet-stream
Size: 9774 bytes
Desc: 0002-drm-amdgpu-amalgamate-PSP-TA-load-unload-functions.patch
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191226/70e60c07/attachment-0005.obj>