[PATCH] drm/amdgpu: don't clamp debugfs register access to the BAR size

Christian König ckoenig.leichtzumerken at gmail.com
Tue Feb 12 10:15:04 UTC 2019


Am 11.02.19 um 22:52 schrieb Alex Deucher via amd-gfx:
> This prevents us from accessing extended registers in tools like
> umr.  The register access functions already check if the offset
> is beyond the BAR size and use the indirect accessors with locking
> so this is safe.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index dd9a4fb9ce39..4ae3ff9a1d4c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -158,9 +158,6 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
>   	while (size) {
>   		uint32_t value;
>   
> -		if (*pos > adev->rmmio_size)
> -			goto end;
> -
>   		if (read) {
>   			value = RREG32(*pos >> 2);
>   			r = put_user(value, (uint32_t *)buf);



More information about the amd-gfx mailing list