[PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

[Bo YU]

Ok, drop it.

On Thu, Feb 14, 2019 at 1:09 PM Zhou, David(ChunMing) <David1.Zhou at amd.com>
wrote:

>
>
> > -----Original Message-----
> > From: Bo YU <tsu.yubo at gmail.com>
> > Sent: Thursday, February 14, 2019 12:46 PM
> > To: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> > <Christian.Koenig at amd.com>; Zhou, David(ChunMing)
> > <David1.Zhou at amd.com>; airlied at linux.ie; daniel at ffwll.ch; Zhu, Rex
> > <Rex.Zhu at amd.com>; Grodzovsky, Andrey
> > <Andrey.Grodzovsky at amd.com>; dri-devel at lists.freedesktop.org; linux-
> > kernel at vger.kernel.org
> > Cc: Bo Yu <tsu.yubo at gmail.com>; amd-gfx at lists.freedesktop.org
> > Subject: [PATCH] drm/amdgpu: Error handling issues about
> > CHECKED_RETURN
> >
> > From: Bo Yu <tsu.yubo at gmail.com>
> >
> > Calling "amdgpu_ring_test_helper" without checking return value
>
> We could need to continue to ring test even there is one ring test failed.
>
> -David
>
> >
> > Signed-off-by: Bo Yu <tsu.yubo at gmail.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > index 57cb3a51bda7..48465a61516b 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> > @@ -4728,7 +4728,9 @@ static int gfx_v8_0_cp_test_all_rings(struct
> > amdgpu_device *adev)
> >
> >       for (i = 0; i < adev->gfx.num_compute_rings; i++) {
> >               ring = &adev->gfx.compute_ring[i];
> > -             amdgpu_ring_test_helper(ring);
> > +             r = amdgpu_ring_test_helper(ring);
> > +             if (r)
> > +                     return r;
> >       }
> >
> >       return 0;
> > --
> > 2.11.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190214/97a6590c/attachment.html>