[PATCH 0/9] PSP cleanup
Christian König
ckoenig.leichtzumerken at gmail.com
Wed Jan 2 10:01:56 UTC 2019
The general idea looks good, but can we change the file and symbol
naming a bit?
So far we have named all non-ip version related functions amdgpu_* and
ip related functions ip_version.
E.g. following this xgmi functions should go into amdgpu_xgmi.c and not
psp_xgmi.c
Christian.
Am 02.01.19 um 10:21 schrieb Evan Quan:
> *** BLURB HERE ***
>
> Evan Quan (9):
> drm/amdgpu: separate the PSP ring related APIs
> drm/amdgpu: separate commonly used PSP APIs
> drm/amdgpu: separate the xgmi related APIs
> drm/amdgpu: separate the tmr related APIs
> drm/amdgpu: separate the asd related APIs
> drm/amdgpu: drop useless PSP APIs and structures
> drm/amdgpu: check PSP support before adding the ip block
> drm/amdgpu: make PSP sub modules(ASD/XGMI/TMR) support configurable
> drm/amdgpu: move psp_funcs related to a more proper place
>
> drivers/gpu/drm/amd/amdgpu/Makefile | 7 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 504 +++-------------------
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 93 +---
> drivers/gpu/drm/amd/amdgpu/psp_asd.c | 86 ++++
> drivers/gpu/drm/amd/amdgpu/psp_asd.h | 32 ++
> drivers/gpu/drm/amd/amdgpu/psp_cmn.c | 289 +++++++++++++
> drivers/gpu/drm/amd/amdgpu/psp_cmn.h | 84 ++++
> drivers/gpu/drm/amd/amdgpu/psp_funcs.h | 98 +++++
> drivers/gpu/drm/amd/amdgpu/psp_ring.c | 354 ++++++++++++++++
> drivers/gpu/drm/amd/amdgpu/psp_ring.h | 43 ++
> drivers/gpu/drm/amd/amdgpu/psp_tmr.c | 84 ++++
> drivers/gpu/drm/amd/amdgpu/psp_tmr.h | 32 ++
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 381 +----------------
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 539 +-----------------------
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 480 +--------------------
> drivers/gpu/drm/amd/amdgpu/psp_xgmi.c | 207 +++++++++
> drivers/gpu/drm/amd/amdgpu/psp_xgmi.h | 33 ++
> drivers/gpu/drm/amd/amdgpu/soc15.c | 13 +-
> 18 files changed, 1493 insertions(+), 1866 deletions(-)
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_asd.c
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_asd.h
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_cmn.c
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_cmn.h
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_funcs.h
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_ring.c
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_ring.h
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_tmr.c
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_tmr.h
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_xgmi.c
> create mode 100644 drivers/gpu/drm/amd/amdgpu/psp_xgmi.h
>
More information about the amd-gfx
mailing list