[PATCH] drm/amdgpu: disable system memory page tables for now

Christian König ckoenig.leichtzumerken at gmail.com
Mon Jan 7 15:06:21 UTC 2019


Am 07.01.19 um 16:03 schrieb Michel Dänzer:
> On 2019-01-07 2:45 p.m., Christian König wrote:
>> We hit a problem with IOMMU with that. Disable until we have time to
>> debug further.
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 4cc0d1079935..ccffcadfd73b 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -847,9 +847,6 @@ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm,
>>   	bp->size = amdgpu_vm_bo_size(adev, level);
>>   	bp->byte_align = AMDGPU_GPU_PAGE_SIZE;
>>   	bp->domain = AMDGPU_GEM_DOMAIN_VRAM;
>> -	if (bp->size <= PAGE_SIZE && adev->asic_type >= CHIP_VEGA10 &&
>> -	    adev->flags & AMD_IS_APU)
>> -		bp->domain |= AMDGPU_GEM_DOMAIN_GTT;
>>   	bp->domain = amdgpu_bo_get_preferred_pin_domain(adev, bp->domain);
>>   	bp->flags = AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS |
>>   		AMDGPU_GEM_CREATE_CPU_GTT_USWC;
>>
> Thanks for taking care of this Christian.

Actually I'm not that happy about this because it seems to point out 
either a hardware problem or a software problem in the IOMMU driver.

I just don't have time to investigate further, so disabling it is the 
least I can do.

> Maybe add a reference to at
> least one of the bug reports about this, but either way:
>
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Thanks,
Christian.


More information about the amd-gfx mailing list