[PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting

Alex Deucher alexdeucher at gmail.com
Tue Jan 8 04:32:26 UTC 2019


Acked-by: Alex Deucher <alexander.deucher at amd.com>

On Mon, Jan 7, 2019 at 11:28 PM Evan Quan <evan.quan at amd.com> wrote:
>
> Since soft min setting is enough. Hard min setting is redundant.
>
> Change-Id: I758386085f227bad94148ec0b38776312b6f5b25
> Reported-by: Likun Gao <Likun.Gao at amd.com>
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> index c2061d351d04..82935a3bd950 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
> @@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_
>                                         (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
>                                         "Failed to set soft min memclk !",
>                                         return ret);
> -
> -               min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level;
> -               PP_ASSERT_WITH_CODE(!(ret = smum_send_msg_to_smc_with_parameter(
> -                                       hwmgr, PPSMC_MSG_SetHardMinByFreq,
> -                                       (PPCLK_UCLK << 16) | (min_freq & 0xffff))),
> -                                       "Failed to set hard min memclk !",
> -                                       return ret);
>         }
>
>         if (data->smu_features[GNLD_DPM_UVD].enabled &&
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list