BISECTED- amd-staging-drm-next, xorg-server segfault A6-6310 APU - R4 Mullins.

[Przemek Socha]

Hi,
after yesterday's fetch of amd-staging-drm-next tree from agd5f git repo my 
xorg server is segfaulting when starting up.

I am using gentoo ~amd64, xorg-server 1.20.3, xf86-video-amdgpu-18.1.0. 
Machine is an old Lenovo g50-45 netbook with A6-6310 APU - R4 Mullins.

- excerpt from Xorg.log:

"[    21.878] (II) AMDGPU(0): Setting screen physical size to 700 x 270
[    21.880] (EE) 
[    21.880] (EE) Backtrace:
[    21.880] (EE) 0: /usr/bin/X (xorg_backtrace+0x4d) [0x559df051f0bd]
[    21.880] (EE) 1: /usr/bin/X (0x559df0376000+0x1acc89) [0x559df0522c89]
[    21.880] (EE) 2: /lib64/libpthread.so.0 (0x7f6f2edad000+0x14560) 
[0x7f6f2edc1560]
[    21.880] (EE) 3: /usr/lib64/xorg/modules/drivers/amdgpu_drv.so 
(0x7f6f2f32b000+0x14fce) [0x7f6f2f33ffce]
[    21.880] (EE) 4: /usr/lib64/xorg/modules/drivers/amdgpu_drv.so 
(0x7f6f2f32b000+0xd1c4) [0x7f6f2f3381c4]
[    21.880] (EE) 5: /usr/bin/X (0x559df0376000+0xdf024) [0x559df0455024]
[    21.881] (EE) 6: /usr/bin/X (InitRootWindow+0x11) [0x559df03f8761]
[    21.881] (EE) 7: /usr/bin/X (0x559df0376000+0x5b574) [0x559df03d1574]
[    21.881] (EE) 8: /lib64/libc.so.6 (__libc_start_main+0xee) 
[0x7f6f2ec054ce]
[    21.881] (EE) 9: /usr/bin/X (_start+0x2a) [0x559df03bb00a]
[    21.881] (EE) 
[    21.881] (EE) Segmentation fault at address 0x4
[    21.881] (EE) 
Fatal server error:
[    21.881] (EE) Caught signal 11 (Segmentation fault). Server aborting
[    21.881] (EE) 
[    21.881] (EE) 
Please consult the The X.Org Foundation support 
	 at http://wiki.x.org
 for help. 
[    21.881] (EE) Please also check the log file at "/var/log/Xorg.0.log" for 
additional information.
[    21.881] (EE) 
[    21.881] (II) AIGLX: Suspending AIGLX clients for VT switch
[    21.957] (EE) Server terminated with error (1). Closing log file."


I am not sure if I didn't mess up anything, but git bisect gives the results:

git bisect log
git bisect start
# good: [d9c54d61df327dc93374b718d7941a09e02e32e1] drm/amdgpu: Add new VegaM 
pci id
git bisect good d9c54d61df327dc93374b718d7941a09e02e32e1
# bad: [d2d07f246b126b23d02af0603b83866a3c3e2483] drm/amdgpu/si: add missing 
header to fix compilation
git bisect bad d2d07f246b126b23d02af0603b83866a3c3e2483
# good: [abc0add47f449a02f8b784d43f4578723fbd6ac9] drm/amdgpu: Add message 
print when unable to get valid hive
git bisect good abc0add47f449a02f8b784d43f4578723fbd6ac9
# bad: [0b0ff923cb4279ee12913dd2b597146538b76a8b] drm/amdgpu: set 
WRITE_BURST_LENGTH to 64B to workaround SDMA1 hang
git bisect bad 0b0ff923cb4279ee12913dd2b597146538b76a8b
# good: [320a0512c8e42fde01be5c47f33fef07d264c6d4] drm/amd/powerplay: create 
pp_od_clk_voltage device file under OD support
git bisect good 320a0512c8e42fde01be5c47f33fef07d264c6d4
# bad: [79c6b898011958fba7722528d567b64e1cdc8dbe] drm/amdgpu: validate user 
pitch alignment
git bisect bad 79c6b898011958fba7722528d567b64e1cdc8dbe
# good: [069d809a94db281efcb6a55f1c0e4a088af0a4cb] drm/amd/powerplay: drop the 
unnecessary uclk hard min setting
git bisect good 069d809a94db281efcb6a55f1c0e4a088af0a4cb
# first bad commit: [79c6b898011958fba7722528d567b64e1cdc8dbe] drm/amdgpu: 
validate user pitch alignment


79c6b898011958fba7722528d567b64e1cdc8dbe is the first bad commit
commit 79c6b898011958fba7722528d567b64e1cdc8dbe
Author: Yu Zhao <yuzhao at google.com>
Date:   Mon Jan 7 15:51:14 2019 -0700

    drm/amdgpu: validate user pitch alignment
    
    Userspace may request pitch alignment that is not supported by GPU.
    Some requests 32, but GPU ignores it and uses default 64 when cpp is
    4. If GEM object is allocated based on the smaller alignment, GPU
    DMA will go out of bound.
    
    Cc: stable at vger.kernel.org # v4.2+
    Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
    Signed-off-by: Yu Zhao <yuzhao at google.com>

:040000 040000 5338964e9975e461ceedb27f6342c2896f54607a 
ed2f04fc9b665b27b1905fd60b7d2a3933d1fdcc M      drivers

Any help is appreciated.

Thanks,
Przemek.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190110/3b6ac713/attachment.sig>