[PATCH] drm/amd/display: Remove error message in stream create routine

Lyude Paul lyude at redhat.com
Thu Jan 10 21:32:55 UTC 2019


On Thu, 2019-01-10 at 16:18 -0500, Jerry (Fangzhi) Zuo wrote:
> MST has its unique sequence that may get failed due to no stream
> in atomic check in some cases, e.g., hotplug, S3 resume.

You might want to elaborate more here, e.g. what's the actual reason for MST
not having streams in the case of a hotplug or S3 resume? Have they not been
created yet, etc. etc.
> 
> Remove the ERROR message in the stream create routine, and leave
> its caller to decide if additional action is required.
> 
> Signed-off-by: Jerry (Fangzhi) Zuo <Jerry.Zuo at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 53c49c901a6a..a9ed225d2ae0 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3052,10 +3052,8 @@ create_stream_for_sink(struct amdgpu_dm_connector
> *aconnector,
>  
>  	stream = dc_create_stream_for_sink(sink);
>  
> -	if (stream == NULL) {
> -		DRM_ERROR("Failed to create stream for sink!\n");
> +	if (stream == NULL)
>  		goto finish;
> -	}
>  
>  	stream->dm_stream_context = aconnector;
>  
-- 
Cheers,
	Lyude Paul



More information about the amd-gfx mailing list