[PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

Koenig, Christian Christian.Koenig at amd.com
Fri Jan 11 09:42:49 UTC 2019


Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey:
> [SNIP]
>>>> But we will not be adding the cb back in drm_sched_stop anymore, now we
>>>> are only going to add back the cb in drm_sched_startr after rerunning
>>>> those jobs in drm_sched_resubmit_jobs and assign them a new parent
>>>> there
>>>> anyway.
>>> Yeah, but when we find that we don't need to reset anything anymore
>>> then adding the callbacks again won't be possible any more.
>>>
>>> Christian.
>> I am not sure I understand it, can u point me to example of how this
>> will happen ? I am attaching my latest patches with waiting only for
>> the last job's fence here just so we are on same page regarding the code.

Well the whole idea is to prepare all schedulers, then check once more 
if the offending job hasn't completed in the meantime.

If the job completed we need to be able to rollback everything and 
continue as if nothing had happened.

Christian.

>>
>> Andrey
>>



More information about the amd-gfx mailing list