[PATCH drm/amdgpu/psp: ignore psp reponse status] drm/amdgpu/psp: ignore psp reponse status
Christian König
ckoenig.leichtzumerken at gmail.com
Mon Jan 14 12:52:12 UTC 2019
Am 14.01.19 um 09:16 schrieb Aaron Liu:
> Don't return err if psp reponse status isn't zero
>
> Change-Id: I680679983f972b6969f4949f1faafaf17fe996a6
> Signed-off-by: Aaron Liu <aaron.liu at amd.com>
Thanks for taking care of that. Fix is Acked-by: Christian König
<christian.koenig at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 53c2d60..48778b3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -140,14 +140,15 @@ psp_cmd_submit_buf(struct psp_context *psp,
> while (*((unsigned int *)psp->fence_buf) != index)
> msleep(1);
>
> - /* the status field must be 0 after psp command completion */
> + /* the status field should be 0 after psp command completion
> + * if not, print WARN msg
> + */
> if (psp->cmd_buf_mem->resp.status) {
> if (ucode)
> - DRM_ERROR("failed to load ucode id (%d) ",
> + DRM_WARN("failed to load ucode id (%d) ",
> ucode->ucode_id);
> - DRM_ERROR("psp command failed and response status is (%d)\n",
> + DRM_WARN("psp command failed and response status is (%d)\n",
> psp->cmd_buf_mem->resp.status);
> - return -EINVAL;
> }
>
> /* get xGMI session id from response buffer */
More information about the amd-gfx
mailing list