答复: [PATCH] drm/amdgpu/soc15: return proper error codes in baco reset

[Qu, Jim]

Reviewed-by: JimQu <Jim.Qu at amd.com>

Thanks
JimQu

________________________________________
发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Alex Deucher <alexdeucher at gmail.com>
发送时间: 2019年1月15日 3:57:56
收件人: amd-gfx at lists.freedesktop.org
抄送: Deucher, Alexander
主题: [PATCH] drm/amdgpu/soc15: return proper error codes in baco reset

Rather than just -1.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/soc15.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 5248b03df5fa..7130a4c8dd5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -427,7 +427,7 @@ static int soc15_asic_get_baco_capability(struct amdgpu_device *adev, bool *cap)

        if (!pp_funcs || !pp_funcs->get_asic_baco_capability) {
                *cap = false;
-               return -1;
+               return -ENOENT;
        }

        return pp_funcs->get_asic_baco_capability(pp_handle, cap);
@@ -439,15 +439,15 @@ static int soc15_asic_baco_reset(struct amdgpu_device *adev)
        const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;

        if (!pp_funcs ||!pp_funcs->get_asic_baco_state ||!pp_funcs->set_asic_baco_state)
-               return -1;
+               return -ENOENT;

        /* enter BACO state */
        if (pp_funcs->set_asic_baco_state(pp_handle, 1))
-               return -1;
+               return -EIO;

        /* exit BACO state */
        if (pp_funcs->set_asic_baco_state(pp_handle, 0))
-               return -1;
+               return -EIO;

        dev_info(adev->dev, "GPU BACO reset\n");

--
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx