[PATCH] drm: Split out drm_probe_helper.h

Jani Nikula jani.nikula at linux.intel.com
Tue Jan 15 10:57:33 UTC 2019

On Tue, 15 Jan 2019, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Having the probe helper stuff (which pretty much everyone needs) in
> the drm_crtc_helper.h file (which atomic drivers should never need) is
> confusing. Split them out.
> To make sure I actually achieved the goal here I went through all
> drivers. And indeed, all atomic drivers are now free of
> drm_crtc_helper.h includes.
> v2: Make it compile. There was so much compile fail on arm drivers
> that I figured I'll better not include any of the acks on v1.
> v3: Massive rebase because i915 has lost a lot of drmP.h includes, but
> not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h
> there was still one, which this patch largely removes. Which means
> rolling out lots more includes all over.
> This will also conflict with ongoing drmP.h cleanup by others I
> expect.
> v3: Rebase on top of atomic bochs.
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com> (v2)
> Acked-by: Benjamin Gaignard <benjamin.gaignard at linaro.org> (v2)
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: virtualization at lists.linux-foundation.org
> Cc: etnaviv at lists.freedesktop.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: intel-gfx at lists.freedesktop.org
> Cc: linux-mediatek at lists.infradead.org
> Cc: linux-amlogic at lists.infradead.org
> Cc: linux-arm-msm at vger.kernel.org
> Cc: freedreno at lists.freedesktop.org
> Cc: nouveau at lists.freedesktop.org
> Cc: spice-devel at lists.freedesktop.org
> Cc: amd-gfx at lists.freedesktop.org
> Cc: linux-renesas-soc at vger.kernel.org
> Cc: linux-rockchip at lists.infradead.org
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> Cc: linux-tegra at vger.kernel.org
> Cc: xen-devel at lists.xen.org
> ---
> Merging this is going to be a bit a mess due to all the ongoing drmP.h
> cleanups. I think the following should work:
> - Apply Sam's prep patches for removing drmP.h from
>   drm_modeset_helper.h
> - Get the i915 drmP.h cleanup backmerged into drm-misc-next
> - Apply this patch.
> - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h
> - All through drm-misc-next, which has some potential for trivial
>   conflicts around #includes with other drivers unfortunately.
> I hope there's no other driver who'll blow up accidentally because
> someone else is doing a drmP.h cleanup. Laurent maybe?
> Jani, ack on this?

Acked-by: Jani Nikula <jani.nikula at intel.com>

Jani Nikula, Intel Open Source Graphics Center

More information about the amd-gfx mailing list