回复：[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

[Zhou, David(ChunMing)]

Reviewed-by: Chunming Zhou <david1.zhou at amd.com>


send from my phone

-------- 原始邮件 --------
主题：[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable
发件人：Christian König
收件人：amd-gfx at lists.freedesktop.org
抄送：

We only need to set this to false now when BOs are removed from the LRU.

Signed-off-by: Christian König <christian.koenig at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index a404ac17e5ae..79f9dde70bc0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -332,7 +332,6 @@ static void amdgpu_vm_bo_base_init(struct amdgpu_vm_bo_base *base,
         if (bo->tbo.resv != vm->root.base.bo->tbo.resv)
                 return;

-       vm->bulk_moveable = false;
         if (bo->tbo.type == ttm_bo_type_kernel)
                 amdgpu_vm_bo_relocated(base);
         else
@@ -698,8 +697,6 @@ int amdgpu_vm_validate_pt_bos(struct amdgpu_device *adev, struct amdgpu_vm *vm,
         struct amdgpu_vm_bo_base *bo_base, *tmp;
         int r = 0;

-       vm->bulk_moveable &= list_empty(&vm->evicted);
-
         list_for_each_entry_safe(bo_base, tmp, &vm->evicted, vm_status) {
                 struct amdgpu_bo *bo = bo_base->bo;

@@ -2775,9 +2772,6 @@ void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
         struct amdgpu_vm_bo_base **base;

         if (bo) {
-               if (bo->tbo.resv == vm->root.base.bo->tbo.resv)
-                       vm->bulk_moveable = false;
-
                 for (base = &bo_va->base.bo->vm_bo; *base;
                      base = &(*base)->next) {
                         if (*base != &bo_va->base)
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190128/85ecdfe8/attachment.html>