[PATCH] drm/amdgpu: Show XGMI node and hive message per device only once

Alex Deucher alexdeucher at gmail.com
Mon Jan 28 17:03:28 UTC 2019


On Mon, Jan 28, 2019 at 12:02 PM Liu, Shaoyun <Shaoyun.Liu at amd.com> wrote:
>
> Reduce the unnecessary repeat node and hive information during XGMI initialization
>
> Change-Id: I1c1e4dadf9d771cde53225666b9a10ceca9167c0
> Signed-off-by: shaoyunl <shaoyun.liu at amd.com>

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index dac18745..0d90672d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -91,10 +91,6 @@ int amdgpu_xgmi_update_topology(struct amdgpu_hive_info *hive, struct amdgpu_dev
>                         "XGMI: Set topology failure on device %llx, hive %llx, ret %d",
>                         adev->gmc.xgmi.node_id,
>                         adev->gmc.xgmi.hive_id, ret);
> -       else
> -               dev_info(adev->dev, "XGMI: Set topology for node %d, hive 0x%llx.\n",
> -                        adev->gmc.xgmi.physical_node_id,
> -                                adev->gmc.xgmi.hive_id);
>
>         return ret;
>  }
> @@ -160,6 +156,9 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)
>                         break;
>         }
>
> +       dev_info(adev->dev, "XGMI: Add node %d, hive 0x%llx.\n",
> +                adev->gmc.xgmi.physical_node_id, adev->gmc.xgmi.hive_id);
> +
>         mutex_unlock(&hive->hive_lock);
>  exit:
>         return ret;
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list