[PATCH] drm/amdgpu: extend AMDGPU_CTX_PRIORITY_NORMAL comment

Christian König ckoenig.leichtzumerken at gmail.com
Mon Jul 15 12:10:12 UTC 2019

Am 02.07.19 um 19:15 schrieb Emil Velikov:
> On Fri, 14 Jun 2019 at 19:02, Koenig, Christian
> <Christian.Koenig at amd.com> wrote:
>> Am 14.06.19 um 19:33 schrieb Emil Velikov:
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>> Currently the AMDGPU_CTX_PRIORITY_* defines are used in both
>>> drm_amdgpu_ctx_in::priority and drm_amdgpu_sched_in::priority.
>>> Extend the comment to mention the CAP_SYS_NICE or DRM_MASTER requirement
>>> is only applicable with the former.
>>> Cc: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>> Cc: Christian König <christian.koenig at amd.com>
>>> Cc: Alex Deucher <alexander.deucher at amd.com>
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>> ---
>>> Mildly curious: why didn't one extend ctx_amdgpu_ctx instead of adding
>>> drm_amdgpu_sched? New flag + _u32 fd at the end (for the former) would
>>> have been enough (and tweaking the ioctl permission thingy).
>> The drm_amdgpu_sched is only allowed for DRM_MASTER.
> Fair enough.
> Is the patch wrong or did it slip through the cracks? I cannot see it
> in Alex's tree.

Looks like Alex just missed this one and I was on vacation/out of office 
for a while.

I've gone ahead added my rb and just pushed it.


> -Emil
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

More information about the amd-gfx mailing list