[PATCH] drm/amdgpu: replace simple_strtol() by kstrtou32()

[Alex Deucher]

On Mon, Jul 15, 2019 at 10:57 AM <xywang.sjtu at sjtu.edu.cn> wrote:
>
> From: Wang Xiayang <xywang.sjtu at sjtu.edu.cn>
>
> The simple_strtol() function is deprecated. kstrto[l,u32]() is
> the correct replacement as it can properly handle overflows.
>
> This patch replaces the deprecated simple_strtol() use introduced recently.
> As clk is of type uint32_t, we are safe to use kstrtou32().
>
> It is also safe to return zero on string parsing error,
> similar to the case of returning zero if buf is empty in parse_clk().
>
> Fixes: bb5a2bdf36a8 ("drm/amdgpu: support dpm level modification under virtualization v3")
> Signed-off-by: Wang Xiayang <xywang.sjtu at sjtu.edu.cn>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 7d484fad3909..2adda47def64 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -386,7 +386,8 @@ static uint32_t parse_clk(char *buf, bool min)
>                  if (!ptr)
>                          break;
>                  ptr+=2;
> -                clk = simple_strtoul(ptr, NULL, 10);
> +               if (kstrtou32(ptr, 10, &clk))
> +                       return 0;
>          } while (!min);
>
>          return clk * 100;
> --
> 2.11.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx