[PATCH] SWDEV-196010 Calltrace caught in amdgpu_vm_sdma.c file

Monk Liu Monk.Liu at amd.com
Tue Jul 16 03:08:46 UTC 2019


don't commit sdma vm job if no updates needed and free
the ib

Signed-off-by: Monk Liu <Monk.Liu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index aeba9e6..ff6d37e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1304,9 +1304,15 @@ int amdgpu_vm_update_directories(struct amdgpu_device *adev,
 			goto error;
 	}
 
-	r = vm->update_funcs->commit(&params, &vm->last_update);
-	if (r)
-		goto error;
+
+	if (params.ib->length_dw > 0) {
+		r = vm->update_funcs->commit(&params, &vm->last_update);
+		if (r)
+			goto error;
+	} else {
+		amdgpu_sa_bo_free(adev, &params.ib->sa_bo, NULL);
+	}
+
 	return 0;
 
 error:
-- 
2.7.4



More information about the amd-gfx mailing list