[PATCH] drm/amd/powerplay: fix memory allocation failure check V2

[Alex Deucher]

On Fri, Jul 12, 2019 at 1:22 AM Evan Quan <evan.quan at amd.com> wrote:
>
> Fix memory allocation failure check.
>
> - V2: fix one more similar error
>
> Change-Id: I012b082a7a2b92973a76db8029897fb4a3441694
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> index 1fc367307ac0..c826e65430b6 100644
> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> @@ -319,7 +319,7 @@ static int vega20_tables_init(struct smu_context *smu, struct smu_table *tables)
>                        AMDGPU_GEM_DOMAIN_VRAM);
>
>         smu_table->metrics_table = kzalloc(sizeof(SmuMetrics_t), GFP_KERNEL);
> -       if (smu_table->metrics_table)
> +       if (!smu_table->metrics_table)
>                 return -ENOMEM;
>         smu_table->metrics_time = 0;
>
> @@ -1502,7 +1502,7 @@ static int vega20_set_default_od8_setttings(struct smu_context *smu)
>
>         od8_settings = kzalloc(sizeof(struct vega20_od8_settings), GFP_KERNEL);
>
> -       if (od8_settings)
> +       if (!od8_settings)
>                 return -ENOMEM;
>
>         smu->od_settings = (void *)od8_settings;
> --
> 2.21.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx