[PATCH 2/2] drm/amd/amdgpu: Add missing select_me_pipe_q() for gfx10

Christian König ckoenig.leichtzumerken at gmail.com
Tue Jul 16 09:20:08 UTC 2019


Am 12.07.19 um 15:44 schrieb StDenis, Tom:
> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index 0d94c812df1b..7d5207bbe382 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -1061,6 +1061,12 @@ static void gfx_v10_0_read_wave_vgprs(struct amdgpu_device *adev, uint32_t simd,
>   		start + SQIND_WAVE_VGPRS_OFFSET, size, dst);
>   }
>   
> +static void gfx_v10_0_select_me_pipe_q(struct amdgpu_device *adev,
> +									  u32 me, u32 pipe, u32 q, u32 vm)

Looks oddly indented, but could as well be just my mail client.

Acked-by: Christian König <christian.koenig at amd.com> when you double 
checked that.

Christian.

> + {
> +       nv_grbm_select(adev, me, pipe, q, vm);
> + }
> +
>   
>   static const struct amdgpu_gfx_funcs gfx_v10_0_gfx_funcs = {
>   	.get_gpu_clock_counter = &gfx_v10_0_get_gpu_clock_counter,
> @@ -1068,6 +1074,7 @@ static const struct amdgpu_gfx_funcs gfx_v10_0_gfx_funcs = {
>   	.read_wave_data = &gfx_v10_0_read_wave_data,
>   	.read_wave_sgprs = &gfx_v10_0_read_wave_sgprs,
>   	.read_wave_vgprs = &gfx_v10_0_read_wave_vgprs,
> +	.select_me_pipe_q = &gfx_v10_0_select_me_pipe_q,
>   };
>   
>   static void gfx_v10_0_gpu_early_init(struct amdgpu_device *adev)



More information about the amd-gfx mailing list