[PATCH 07/87] drm/amd/display: move bw calc code into helpers

Michel Dänzer michel at daenzer.net
Thu Jul 18 14:49:56 UTC 2019


On 2019-07-15 11:19 p.m., sunpeng.li at amd.com wrote:
> From: Eric Yang <Eric.Yang2 at amd.com>
> 
> [Why]
> For better readability and reusability
> 
> [How]
> Move snippets of BW calculation code into helpers.
> 
> Signed-off-by: Eric Yang <Eric.Yang2 at amd.com>
> Reviewed-by: Fatemeh Darbehani <Fatemeh.Darbehani at amd.com>
> Acked-by: Leo Li <sunpeng.li at amd.com>
> ---
>  [...]
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 086d2f3b0db3..e9ccf41e31ee 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -126,6 +126,7 @@ static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
>  		amdgpu_device_get_pcie_replay_count, NULL);
>  
>  static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev);
> +static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);

This function isn't defined anywhere, producing a warning:

drivers/gpu/drm//amd/amdgpu/amdgpu_device.c:131:13: warning: ‘amdgpu_device_parse_faked_did’ declared ‘static’ but never defined [-Wunused-function]
 static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list