[PATCH] drm/amdgpu: Prefer pcie_capability_read_word()
bhelgaas at google.com
Thu Jul 18 12:58:52 UTC 2019
On Wed, Jul 17, 2019 at 9:08 PM Frederick Lawler <fred at fredlawl.com> wrote:
> Commit 8c0d3a02c130 ("PCI: Add accessors for PCI Express Capability")
> added accessors for the PCI Express Capability so that drivers didn't
> need to be aware of differences between v1 and v2 of the PCI
> Express Capability.
> Replace pci_read_config_word() and pci_write_config_word() calls with
> pcie_capability_read_word() and pcie_capability_write_word().
> Signed-off-by: Frederick Lawler <fred at fredlawl.com>
> - pci_read_config_word(adev->pdev, gpu_pos + PCI_EXP_LNKCTL2, &tmp16);
> + pcie_capability_read_word(adev->pdev,
> + PCI_EXP_LNKCTL2,
> + &tmp16);
> tmp16 &= ~((1 << 4) | (7 << 9));
> tmp16 |= (gpu_cfg2 & ((1 << 4) | (7 << 9)));
Same comments as for radeon. Looks like a lot of similar code between
radeon and amdgpu.
More information about the amd-gfx