[RFC PATCH 0/3] Propose new struct drm_mem_region
Brian Welty
brian.welty at intel.com
Tue Jul 30 00:32:22 UTC 2019
[ By request, resending to include amd-gfx + intel-gfx. Since resending,
I fixed the nit with ordering of header includes that Sam noted. ]
This RFC series is first implementation of some ideas expressed
earlier on dri-devel [1].
Some of the goals (open for much debate) are:
- Create common base structure (subclass) for memory regions (patch #1)
- Create common memory region types (patch #2)
- Create common set of memory_region function callbacks (based on
ttm_mem_type_manager_funcs and intel_memory_regions_ops)
- Create common helpers that operate on drm_mem_region to be leveraged
by both TTM drivers and i915, reducing code duplication
- Above might start with refactoring ttm_bo_manager.c as these are
helpers for using drm_mm's range allocator and could be made to
operate on DRM structures instead of TTM ones.
- Larger goal might be to make LRU management of GEM objects common, and
migrate those fields into drm_mem_region and drm_gem_object strucures.
Patches 1-2 implement the proposed struct drm_mem_region and adds
associated common set of definitions for memory region type.
Patch #3 is update to i915 and is based upon another series which is
in progress to add vram support to i915 [2].
[1] https://lists.freedesktop.org/archives/dri-devel/2019-June/224501.html
[2] https://lists.freedesktop.org/archives/intel-gfx/2019-June/203649.html
Brian Welty (3):
drm: introduce new struct drm_mem_region
drm: Introduce DRM_MEM defines for specifying type of drm_mem_region
drm/i915: Update intel_memory_region to use nested drm_mem_region
drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 10 ++---
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
drivers/gpu/drm/i915/i915_query.c | 2 +-
drivers/gpu/drm/i915/intel_memory_region.c | 10 +++--
drivers/gpu/drm/i915/intel_memory_region.h | 19 +++------
drivers/gpu/drm/i915/intel_region_lmem.c | 26 ++++++-------
.../drm/i915/selftests/intel_memory_region.c | 8 ++--
drivers/gpu/drm/ttm/ttm_bo.c | 34 +++++++++-------
drivers/gpu/drm/ttm/ttm_bo_manager.c | 14 +++----
drivers/gpu/drm/ttm/ttm_bo_util.c | 11 +++---
drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 8 ++--
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 4 +-
include/drm/drm_mm.h | 39 ++++++++++++++++++-
include/drm/ttm/ttm_bo_api.h | 2 +-
include/drm/ttm/ttm_bo_driver.h | 16 ++++----
include/drm/ttm/ttm_placement.h | 8 ++--
18 files changed, 124 insertions(+), 93 deletions(-)
--
2.21.0
More information about the amd-gfx
mailing list