[PATCH 03/13] nouveau: pass struct nouveau_svmm to nouveau_range_fault
jgg at mellanox.com
Tue Jul 30 13:14:58 UTC 2019
On Tue, Jul 30, 2019 at 03:10:38PM +0200, Christoph Hellwig wrote:
> On Tue, Jul 30, 2019 at 12:35:59PM +0000, Jason Gunthorpe wrote:
> > On Tue, Jul 30, 2019 at 08:51:53AM +0300, Christoph Hellwig wrote:
> > > This avoid having to abuse the vma field in struct hmm_range to unlock
> > > the mmap_sem.
> > I think the change inside hmm_range_fault got lost on rebase, it is
> > now using:
> > up_read(&range->hmm->mm->mmap_sem);
> > But, yes, lets change it to use svmm->mm and try to keep struct hmm
> > opaque to drivers
> It got lost somewhat intentionally as I didn't want the churn, but I
> forgot to update the changelog. But if you are fine with changing it
> over I can bring it back.
I have a patch deleting hmm->mm, so using svmm seems cleaner churn
here, we could defer and I can fold this into that patch?
More information about the amd-gfx