[PATCH 06/13] mm: remove superflous arguments from hmm_range_register
Jason Gunthorpe
jgg at mellanox.com
Tue Jul 30 17:51:00 UTC 2019
On Tue, Jul 30, 2019 at 08:51:56AM +0300, Christoph Hellwig wrote:
> The start, end and page_shift values are all saved in the range
> structure, so we might as well use that for argument passing.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> Documentation/vm/hmm.rst | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +++++--
> drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++---
> include/linux/hmm.h | 6 +-----
> mm/hmm.c | 20 +++++---------------
> 5 files changed, 14 insertions(+), 26 deletions(-)
I also don't really like how the API sets up some things in the struct
and some things via arguments, so:
Reviewed-by: Jason Gunthorpe <jgg at mellanox.com>
Jason
More information about the amd-gfx
mailing list