Review required [Was: Associate ddc adapters with connectors]
narmstrong at baylibre.com
Wed Jul 31 08:00:14 UTC 2019
On 26/07/2019 20:55, Sam Ravnborg wrote:
> Hi all.
> Andrzej have done a good job following up on feedback and this series is
> now ready.
> We need ack on the patches touching the individual drivers before we can
> Please check your drivers and get back.
I can apply all core and maintainer-acked patches for now :
1, 2, 7, 10, 11, 16, 17, 18, 19, 20, 21, 22, 23
and Andrzej can resend not applied patches with Yours and Emil's Reviewed-by,
so we can wait a few more days to apply them.
>> Hi Andezej.
>> On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote:
>>> It is difficult for a user to know which of the i2c adapters is for which
>>> drm connector. This series addresses this problem.
>>> The idea is to have a symbolic link in connector's sysfs directory, e.g.:
>>> ls -l /sys/class/drm/card0-HDMI-A-1/ddc
>>> lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
>>> -> ../../../../soc/13880000.i2c/i2c-2
>>> The user then knows that their card0-HDMI-A-1 uses i2c-2 and can e.g. run
>>> ddcutil -b 2 getvcp 0x10
>>> VCP code 0x10 (Brightness): current value = 90, max value = 100
>>> The first patch in the series adds struct i2c_adapter pointer to struct
>>> drm_connector. If the field is used by a particular driver, then an
>>> appropriate symbolic link is created by the generic code, which is also added
>>> by this patch.
>>> Patch 2 adds a new variant of drm_connector_init(), see the changelog
>>> Patches 3..24 are examples of how to convert a driver to this new scheme.
>>> - improved subject line of patch 1
>>> - added kernel-doc for drm_connector_init_with_ddc()
>>> - improved kernel-doc for the ddc field of struct drm_connector
>>> - added Reviewed-by in patches 17 and 18
>>> - added Acked-by in patch 2
>>> - made the ownership of ddc i2c_adapter explicit in all patches,
>>> this made the affected patches much simpler
>> Looks good now.
>> Patch 1 and 2 are:
>> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>
>> The remaining patches are:
>> Acked-by: Sam Ravnborg <sam at ravnborg.org>
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
More information about the amd-gfx