[PATCH 02/13] amdgpu: don't initialize range->list in amdgpu_hmm_init_range

Jason Gunthorpe jgg at mellanox.com
Wed Jul 31 17:02:24 UTC 2019

On Wed, Jul 31, 2019 at 01:25:06PM +0000, Kuehling, Felix wrote:
> On 2019-07-30 1:51 a.m., Christoph Hellwig wrote:
> > The list is used to add the range to another list as an entry in the
> > core hmm code, so there is no need to initialize it in a driver.
> I've seen code that uses list_empty to check whether a list head has 
> been added to a list or not. For that to work, the list head needs to be 
> initialized, and it has to be removed with list_del_init. 

I think the ida is that 'list' is a private member of range and
drivers shouldn't touch it at all.

> ever do that with range->list, then this patch is Reviewed-by: Felix 
> Kuehling <Felix.Kuehling at amd.com>

Please put tags on their own empty line so that patchworks will
collect them automatically..


More information about the amd-gfx mailing list