[PATCH v2] dri2: reply to client for WaitMSC request in any case

[Cui, Flora]

Yes. It's v2 and change the behavior slightly.

It send reply to client with no wait_info for

amdgpu_dri2_deferred_event() would handle the reply differently.

在 6/3/2019 3:59 PM, Ernst Sjöstrand 写道:
> This looks like a v2 with silightly different semantics?
>
> Den mån 3 juni 2019 kl 09:26 skrev Cui, Flora <fcui at amd.com>:
>> ping...
>>
>> commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469
>> Author: Flora Cui <flora.cui at amd.com>
>> Date:   Wed May 29 14:18:50 2019 +0800
>>
>>       dri2: reply to client for WaitMSC request in any case
>>
>>       otherwise client would wait for reply forever and desktop appears hang.
>>
>>       Signed-off-by: Flora Cui <flora.cui at amd.com>
>>
>> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
>> index 44316ac..bb3d9d0 100644
>> --- a/src/amdgpu_dri2.c
>> +++ b/src/amdgpu_dri2.c
>> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr
>> client, DrawablePtr draw,
>>    out_complete:
>>           if (wait_info)
>>                   amdgpu_dri2_deferred_event(NULL, 0, wait_info);
>> +       else
>> +               DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
>> +
>>           return TRUE;
>>    }
>>
>> 在 5/29/2019 2:36 PM, Cui, Flora 写道:
>>> otherwise client would wait for reply forever and desktop appears hang.
>>>
>>> Signed-off-by: Flora Cui <flora.cui at amd.com>
>>> ---
>>>    src/amdgpu_dri2.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c
>>> index 44316ac..34353a7 100644
>>> --- a/src/amdgpu_dri2.c
>>> +++ b/src/amdgpu_dri2.c
>>> @@ -1062,6 +1062,9 @@ static int amdgpu_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw,
>>>    out_complete:
>>>        if (wait_info)
>>>                amdgpu_dri2_deferred_event(NULL, 0, wait_info);
>>> +
>>> +     DRI2WaitMSCComplete(client, draw, target_msc, 0, 0);
>>> +
>>>        return TRUE;
>>>    }
>>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx