答复: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov

[Tao, Yintian]

Yes, you are right the error message is at wrong place.


May I just remove this message?



Best Regards

Yintian Tao

________________________________
发件人: Koenig, Christian
发送时间: 2019年6月4日 23:22:00
收件人: Tao, Yintian; amd-gfx at lists.freedesktop.org
主题: Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov

Am 04.06.19 um 17:16 schrieb Tao, Yintian:

Hi  Christian


But when amdgpu driver is unloading, it will call this function.


And driver unloading is an legal case under SR-IOV.


Do you mean PCIe device removal indicates the unplug the real device?

Yes, exactly and that is not supported.

Sounds like the error message is then on the wrong place.

Christian.



Best Regards

Yitnian Tao

________________________________
发件人: Christian König <ckoenig.leichtzumerken at gmail.com><mailto:ckoenig.leichtzumerken at gmail.com>
发送时间: 2019年6月4日 21:57:37
收件人: Tao, Yintian; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov

Am 04.06.19 um 15:43 schrieb Yintian Tao:
> Under Sriov, there is no need of the support for fbcon.

NAK, that error message is not related to fbcon but means that PCIe
device removal is not supported.

Christian.

>
> Signed-off-by: Yintian Tao <yttao at amd.com><mailto:yttao at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 1f38d6f..28d095b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
>   {
>        struct drm_device *dev = pci_get_drvdata(pdev);
>
> -     DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
> +     if (!amdgpu_sriov_vf(adev))
> +             DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
>        drm_dev_unplug(dev);
>        drm_dev_put(dev);
>        pci_disable_device(pdev);


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190604/fe8d67a3/attachment.html>