[PATCH v1 01/10] drm: fix build errors with drm_print.h

Sam Ravnborg sam at ravnborg.org
Tue Jun 11 10:37:12 UTC 2019

Hi Daniel.

> > 
> > drm_print.h uses DRM_NAME - which is defined only in uapi/drm/drm.h.
> > The error is seen when you include drm_print.h and not much other drm
> > header files.
> > Tiday we rely on other drm header files to pull in drm.h.
> > 
> > Notice - the error only manifest itself when the macros are used.
> > Including the drm_print.h will not do it.
> Uh, I think let's just inline DRM_NAME, that also cleans up the code. And
> drop the uapi include from drm internal headers, that feels bad. In
> general I think uapi headers should only be included by the .c files that
> actually implement ioctls and stuff like that.
> Can you pls do that patch for drm_print.h?

Yep - will do in a few days.


More information about the amd-gfx mailing list