[PATCH] radeon: no need to check return value of debugfs_create functions

Alex Deucher alexdeucher at gmail.com
Thu Jun 13 14:54:41 UTC 2019


On Thu, Jun 13, 2019 at 7:56 AM Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
>
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Christian K├Ânig" <christian.koenig at amd.com>
> Cc: "David (ChunMing) Zhou" <David1.Zhou at amd.com>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: amd-gfx at lists.freedesktop.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Applied all the radeon and amdgpu patches.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 5d42f8d8e68d..6bbccc796e40 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1056,19 +1056,14 @@ static int radeon_ttm_debugfs_init(struct radeon_device *rdev)
>         unsigned count;
>
>         struct drm_minor *minor = rdev->ddev->primary;
> -       struct dentry *ent, *root = minor->debugfs_root;
> -
> -       ent = debugfs_create_file("radeon_vram", S_IFREG | S_IRUGO, root,
> -                                 rdev, &radeon_ttm_vram_fops);
> -       if (IS_ERR(ent))
> -               return PTR_ERR(ent);
> -       rdev->mman.vram = ent;
> -
> -       ent = debugfs_create_file("radeon_gtt", S_IFREG | S_IRUGO, root,
> -                                 rdev, &radeon_ttm_gtt_fops);
> -       if (IS_ERR(ent))
> -               return PTR_ERR(ent);
> -       rdev->mman.gtt = ent;
> +       struct dentry *root = minor->debugfs_root;
> +
> +       rdev->mman.vram = debugfs_create_file("radeon_vram", S_IFREG | S_IRUGO,
> +                                             root, rdev,
> +                                             &radeon_ttm_vram_fops);
> +
> +       rdev->mman.gtt = debugfs_create_file("radeon_gtt", S_IFREG | S_IRUGO,
> +                                            root, rdev, &radeon_ttm_gtt_fops);
>
>         count = ARRAY_SIZE(radeon_ttm_debugfs_list);
>
> --
> 2.22.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the amd-gfx mailing list